Revert "src: make process.env.TZ setter clear tz cache"#20228
Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Closed
Revert "src: make process.env.TZ setter clear tz cache"#20228BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Conversation
This reverts commit 1d1ab76.
nodejs-github-bot
added
the
c++
Member
Author
addaleax
approved these changes
Apr 23, 2018
joyeecheung
approved these changes
Apr 23, 2018
jasnell
approved these changes
Apr 23, 2018
Member
Author
|
Landed in e767aa1 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 23, 2018
This reverts commit 1d1ab76. PR-URL: nodejs#20228 Fixes: nodejs#20227 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1d1ab76.
Fixes: #20227
When landing #20026 I missed failures on Alpine and I could not find a easy way to detect Alpine builds right now, so I decided to revert this until we find a proper fix.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes